Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup base for PortingEmbed #1

Merged
merged 7 commits into from
Feb 20, 2024
Merged

Setup base for PortingEmbed #1

merged 7 commits into from
Feb 20, 2024

Conversation

timomeh
Copy link
Member

@timomeh timomeh commented Feb 19, 2024 •
edited
Loading

  • Add new PortingEmbed
  • Add safeguards that the embed is initialized with the correct data
  • Exchange session token with user token
  • Prefetch the subscription and ensure a supported porting is present
  • Renamed lib/main.ts to lib/index.ts because "main" is just another word for "index", and "index" is the more conventional name.
  • Add fixtures with fishery for better testing

@timomeh timomeh marked this pull request as ready for review February 20, 2024 10:19
@timomeh
Copy link
Member Author

timomeh commented Feb 20, 2024

I noticed and fixed that the built library did not contain the JSDoc annotations. And I added some more.

@timomeh timomeh merged commit 56e2ba9 into main Feb 20, 2024
3 checks passed
@timomeh timomeh deleted the timo/conn-678-initialize-the-embed-and-exchange-a-token branch February 20, 2024 13:25
@gigs gigs deleted a comment from linear bot Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dharmadeveloper108 dharmadeveloper108 Awaiting requested review from dharmadeveloper108

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@timomeh